inveniosoftware
diff: allow tolerance only between floats
Description
For https://github.com/inveniosoftware/dictdiffer/issues/181
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
- [x] I'm aware of the code of conduct.
- [x] I've created logical separate commits and followed the commit message format.
- [x] I've added relevant test cases.
- [x] I've added relevant documentation.
- [x] I've marked translation strings (for relevant code).
- [x] I've followed the CSS/JS and React guidelines (for relevant code).
- [x] I've followed the web accessibility guidelines (for relevant code).
- [x] I've followed the user interface guidelines (for relevant code).
- [x] I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
- [x] I've NOT included third-party code (copy/pasted source code or new dependencies).
Third-party code
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:
- You license your contribution under the same terms as the current repository’s license.
- You agree that you have the right to license your contribution under the current repository’s license.
Instead of this change, why don't we set the default tolerance to 1e-int_Max?
There is no int_Max: https://docs.python.org/3/whatsnew/3.0.html#integers
Applying any tolerance for integers would impose a guess as to what magnitudes of numbers people are likely to use or what range of values one's test suite can accept. The tolerance parameter's stated goal of allowing floating point imprecision isn't applicable to integers