Add rubocop to spot code related issues

Open tmaier opened this issue 3 years ago • 3 comments

After this has been merged, we could start resolving some of the issues identified

[ ] It would be great to run rubocop also as GitHub workflow. Contribution welcomed

Apr 22 '22 13:04 tmaier

@mapreal19 added this at some point too. I generally think it's a good idea, however, we never really acted on the flagged issues and so it just got in the way when fixing small issues here and there. That's why I removed it again after a while. So you're welcome to add this, I'd just caution to make sure it helps instead of getting in the way.

See https://github.com/inukshuk/bibtex-ruby/pull/136

Apr 22 '22 17:04 inukshuk

I guess it depends on the commit frequency from now on, if we're only bug-fixing then doesn't help that much now

Apr 26 '22 10:04 mapreal19