oauth-pythonclient icon indicating copy to clipboard operation
oauth-pythonclient copied to clipboard
verified publisher icon intuit

Remove future dependency

Open alanyee opened this issue 5 years ago • 1 comments

Using a thirdparty dependency as big as future for just urlencode() does not seem worth it

alanyee avatar Sep 30 '20 22:09 alanyee

Please consider this PR. future triggers a warning on Python 3.8:

  /.../future/standard_library/__init__.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

intuit-oauth is the only package in the project I'm looking at that requires future.

It would also make sense to remove Python 2 compatibility altogether, since it was EOL nearly 2 years ago.

adamchainz avatar Jan 26 '22 11:01 adamchainz

This is needed for python 3.12.

Please consider this PR @nicholas-ramsey as this library is no longer compatible with python 3.12.

uptickmetachu avatar Oct 10 '23 03:10 uptickmetachu

@alanyee This has been implemented, seems like this can be closed.

bdsoha avatar Feb 18 '24 06:02 bdsoha

@bdsoha I will close this PR since it is no longer needed, but this PR was to make it Python 2 compatible. With the new change, Python 3 should be enforced by setup.py which I will make a PR for.

alanyee avatar Feb 21 '24 03:02 alanyee

#46 is the small iteration of this PR

alanyee avatar Feb 21 '24 04:02 alanyee