node-pom-parser icon indicating copy to clipboard operation
node-pom-parser copied to clipboard

not able to pass parser options

Open orneryd opened this issue 8 years ago • 6 comments

the options are hardcoded and cannot be overriden. You should retain key camelcasing by default.

orneryd avatar Mar 22 '17 18:03 orneryd

@nsinghal12 I don't see the options being hardcoded anywhere. Not valid anymore I guess.

foobar98 avatar Oct 15 '22 08:10 foobar98

@foobar98 Parser options are hardcoded at line 10. This is a valid issue.

nsinghal12 avatar Oct 19 '22 06:10 nsinghal12

Okay, I thought he meant the main parse options. What should be the ideal solution in this case then - clients can pass xmljsOptions as part of the parse options? And if nothing is provided we default to our hardcoded values?

foobar98 avatar Oct 19 '22 14:10 foobar98

@foobar98 Yes, we should add these options to the first argument in parse call and fallback to defaults when not provided.

nsinghal12 avatar Oct 28 '22 04:10 nsinghal12

This issue is available to be picked up for hacktoberfest. Please comment here if anyone wants to pick this one.

nsinghal12 avatar Oct 28 '22 04:10 nsinghal12

Willing to take this if nobody else is.

foobar98 avatar Oct 29 '22 09:10 foobar98