devtools-ds icon indicating copy to clipboard operation
devtools-ds copied to clipboard

ObjectInspector: Add Name

Open tylerkrupicka opened this issue 5 years ago • 2 comments

What Changed

Closes https://github.com/intuit/devtools-ds/issues/14

Added a name prop to ObjectInspector to support named root values, similar to how Storybook currently names the object root. In the process I also fixed the color of the colon after a key in the object label.

Why

What might be impacted

Todo:

  • [x] Add tests
  • [x] Add docs
📦 Published PR as canary version: 1.0.4-canary.15.363.0

:sparkles: Test out this PR locally via:

npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
npm install @devtools-ds/[email protected]
# or 
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]
yarn add @devtools-ds/[email protected]

tylerkrupicka avatar Feb 23 '21 04:02 tylerkrupicka

Bundle Size Report

name master pr +/- %
@devtools-ds/themes 6.01 kB 6.07 kB 59.00 Bytes 0.98%
@devtools-ds/object-inspector 23.92 kB 24.26 kB 343.00 Bytes 1%
Total 29.93 kB 30.33 kB 402.00 Bytes 1%

✅ No size breaking changes detected

Courtesy of your bundle-size bot :package::rocket:

tylerkrupicka avatar Feb 23 '21 04:02 tylerkrupicka

Build Info

Your PR was successfully deployed by CircleCI #364

Storybook

tylerkrupicka avatar Mar 14 '21 23:03 tylerkrupicka