bookreader icon indicating copy to clipboard operation
bookreader copied to clipboard

Move `pageChanged` event name into events.js

Open iisa opened this issue 5 years ago • 14 comments

Task:

  • Update events 'list' to include new field: pageChanged = 'pageChanged';
  • find all the places pageChanged is used, and point it to its new reference (events.pageChanged)
  • Make sure that the event BookReader:pageChanged is emitted when changing the page
  • Make sure all tests pass

https://github.com/internetarchive/bookreader/blob/master/src/js/BookReader/events.js

iisa avatar Sep 30 '20 20:09 iisa

Hi, I would like to take up this issue. Could this be assigned to me @iisa

nynaalekhya avatar Sep 30 '20 21:09 nynaalekhya

hi @nynaalekhya i apologize for not getting you assigned quickly. We will go with the current PR that is open since it is being worked on. Would you like to take this one instead? https://github.com/internetarchive/bookreader/issues/487

iisa avatar Oct 03 '20 15:10 iisa

@iisa mam can you assign a issue to me as well please

ArunTeltia avatar Oct 04 '20 04:10 ArunTeltia

@iisa if this issue is still available kindly assign it to me. Thanks :)

DhairyaBahl avatar Oct 13 '20 16:10 DhairyaBahl

@iisa Please review my pull request and guide for further changes. #559

Chaitanya31612 avatar Nov 22 '20 18:11 Chaitanya31612

@iisa Please review my pull request and guide for further changes. #559

@iisa I've made pull request of requested changes. please review it and guide for any other change whatsoever is required. #559

Chaitanya31612 avatar Dec 01 '20 10:12 Chaitanya31612

I would like to take this issue.

harshhx avatar Dec 21 '20 18:12 harshhx

I would like to work on this issue if it's still open @iisa I have been doing web development in javascript for a year now and would like to enter the open source world.

hkumar0132 avatar Jan 09 '21 15:01 hkumar0132

Mam,Can i solve this issue

codewithsantosh avatar Feb 02 '21 17:02 codewithsantosh

Mam, May I work on this issue?

vishwjeet-singh avatar Mar 03 '21 10:03 vishwjeet-singh

Is this issue open? I would like to work on it.

Priyaraj17 avatar Mar 15 '21 11:03 Priyaraj17

close the issue please if is resolve

GeraAlcantara avatar Oct 04 '21 23:10 GeraAlcantara

Is this issue still open? I would like to work on it.

vishavsingla avatar Apr 04 '23 09:04 vishavsingla