interbtc icon indicating copy to clipboard operation
interbtc copied to clipboard
verified publisher icon interlay

[BREAKING] refactor!: remove refund

Open gregdhill opened this issue 3 years ago • 1 comments

Signed-off-by: Gregory Hill [email protected]

Apart from the obvious reduction in complexity the primary motivation of this change is to remove the last part of code which (incorrectly) extracts the BtcAddress from a TransactionInput. This protocol was not incentivized and since the removal of theft reporting Vaults can anyway return excess BTC out-of-bounds.

Breaking Changes

  • Removed Refund pallet with associated extrinsics, storage and events
  • Changed IssueRequestStatus::Completed(Option<H256>) to IssueRequestStatus::Completed

gregdhill avatar Aug 05 '22 14:08 gregdhill

I'm in favor of removing, but I'd note that on Kintsugi we've had 13 refund requests, all of which have been executed. Did @nud3l sign off on this change? Edit: yes he did. How should we go about releasing this? This'll need its own dedicated referendum

sander2 avatar Aug 11 '22 15:08 sander2

@sander2 do you think we should explicitly clear storage (for refund) in the migration?

gregdhill avatar Sep 15 '22 15:09 gregdhill

@sander2 do you think we should explicitly clear storage (for refund) in the migration?

We could, yea, or we can manually do a kill_prefix together with the 1.20 upgrade

sander2 avatar Sep 15 '22 15:09 sander2