interbtc icon indicating copy to clipboard operation
interbtc copied to clipboard

feat: fork collator-selection and use escrow for bonding

Open gregdhill opened this issue 3 years ago • 1 comments

Signed-off-by: Gregory Hill [email protected]

Forks pallet-collator-selection and distinguishes StakingCurrency and RewardsCurrency so that we can use the illiquid Escrow balance for candidacy bonds.

The reason for the split is because the ReservableCurrency implementation on the Escrow pallet is incompatible with the calls made in note_author.

gregdhill avatar Aug 01 '22 14:08 gregdhill

Any chance you can split up your pr in at least 2 separate commits - one where you just add unchanged forked pallet, and one with the changes you made to it? The current pr with a single commit is quite hard to review

sander2 avatar Aug 17 '22 13:08 sander2

Wouldn't switching over without migration lead to their KINT/INTR being locked forever? And wouldn't it lead to problems when existing collators quit, as we would attempt to unlock vKINT but didn't lock?

This is not a problem because we have not yet enabled registration.

gregdhill avatar Aug 22 '22 12:08 gregdhill