intercom-rails icon indicating copy to clipboard operation
intercom-rails copied to clipboard

Add Turbolinks support

Open kritik opened this issue 9 years ago • 6 comments

Majority of Rails applications use Turbolinks. So, it's helpful to support them

kritik avatar Aug 03 '16 06:08 kritik

Just what I needed. Hope this gets merged into the main repo.

DJNgoma avatar Sep 06 '16 08:09 DJNgoma

"The command "bundle exec rake" exited with 1." - So not my code problem

kritik avatar Sep 06 '16 08:09 kritik

Hello, this PR has compability only with the older Turbolinks version. Because you are listening "page:load" (the old way) instead of "turbolinks:load" (the current version).

Check the Should I use Turbolinks 5 or Turbolinks Classic? section: https://github.com/turbolinks/turbolinks/wiki/Turbolinks-5-FAQ

serradura avatar Oct 01 '16 12:10 serradura

Majority of Rails applications

Not so sure about that..

koenpunt avatar Oct 17 '16 01:10 koenpunt

I am using Turbolinks 5 and I never had problems with the Intercom Widget ?? (Or maybe I had problems all along but I didn't notice :o )

EDIT : nvm, this is just for the first page load, but if you need to push data on every "turbolinked" page then I haven't tested.

Startouf avatar Oct 24 '16 14:10 Startouf

@Startouf may be because you load this widget on every page?

kritik avatar Oct 24 '16 14:10 kritik