zephyr.js icon indicating copy to clipboard operation
zephyr.js copied to clipboard

signal_callback should return an error when ring buf full

Open grgustaf opened this issue 8 years ago • 0 comments

When the ring buffer is too full, signalling a callback fails. To behave correctly, the caller should probably find out this and even though it's a pretty bad error, they can avoid making things worse by freeing up resources.

So probably the return value should be changed to something other than void and all callsites checked for proper error handling.

grgustaf avatar Feb 01 '18 17:02 grgustaf