llvm icon indicating copy to clipboard operation
llvm copied to clipboard
verified publisher icon intel

[SYCL] Rename optional device feature metadata

Open steffenlarsen opened this issue 3 years ago • 4 comments

This commit renames metadata nodes introduced by the optional device features design document from using intel_ prefix to use sycl_ prefix.

steffenlarsen avatar Sep 20 '22 11:09 steffenlarsen

Related to discussion https://github.com/intel/llvm/pull/6804#discussion_r973560548

steffenlarsen avatar Sep 20 '22 11:09 steffenlarsen

@steffenlarsen I see you've changed the documentation for intel_fixed_targets but I don't see where you actually changed the name in code. Can you plase point me to it?

intel_fixed_targets has not been introduced yet, so no actual changes are needed for it.

I suppose intel_reqd_group_size will also be renamed? In a separate patch maybe?

intel_reqd_group_size is not new to the optional device features design so the renaming should happen separately.

steffenlarsen avatar Sep 20 '22 14:09 steffenlarsen

@steffenlarsen I see you've changed the documentation for intel_fixed_targets but I don't see where you actually changed the name in code. Can you plase point me to it?

intel_fixed_targets has not been introduced yet, so no actual changes are needed for it.

Thanks for clarifying!

elizabethandrews avatar Sep 20 '22 14:09 elizabethandrews

I suppose intel_reqd_group_size will also be renamed? In a separate patch maybe?

intel_reqd_group_size is not new to the optional device features design so the renaming should happen separately.

I have created https://github.com/intel/llvm/issues/6824 for this

smanna12 avatar Sep 20 '22 14:09 smanna12