llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Add pass to finish SROA for cooperative matrices

Open MrSidims opened this issue 1 year ago • 2 comments

SROA has troubles processing structures containing TargetExtType, which in some cases will lead to a situation, when OpAccessChain would attempt to access a structure containing a cooperative matrix, but with indexes set to access the matrix itself, which is invalid. This PR adds routine that finds alloca to such structure and replaces it with alloca to cooperative matrix type.

MrSidims avatar Aug 12 '24 12:08 MrSidims

@bwlodarcz @VyacheslavLevytskyy for some reasons can't add you as reviewers, yet please take a look when convenient

MrSidims avatar Aug 12 '24 15:08 MrSidims

@AlexeySachkov thanks for the suggestions! Applied comments and move to be a pass executed during sycl-post-link.

MrSidims avatar Aug 26 '24 20:08 MrSidims

@intel/dpcpp-tools-reviewers @intel/dpcpp-esimd-reviewers please take a look

MrSidims avatar Aug 29 '24 12:08 MrSidims

@intel/llvm-gatekeepers please help with merge

MrSidims avatar Sep 02 '24 23:09 MrSidims

Failure on Windows is after testing and is infrastructural.

steffenlarsen avatar Sep 03 '24 06:09 steffenlarsen

@MrSidims Seeing postcommit XPASS failures on DG2, can you take a look?

https://github.com/intel/llvm/actions/runs/10678654371/job/29596502570

sarnex avatar Sep 03 '24 14:09 sarnex