llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL] Add more aspect information for intel_gpu_* in device config file

Open jzc opened this issue 1 year ago • 1 comments

jzc avatar Jun 14 '24 21:06 jzc

Hi,

Any comments about the failing tests?

Thanks

asudarsa avatar Jun 18 '24 15:06 asudarsa

LGTM. Is this supported by any existing tests? Will we benefit for adding tests here? I am ok with adding test in a subsequent PR.

There is a couple of tests: test-e2e/AOT/reqd-sg-size.cpp, test-e2e/AOT/double.cpp that perform E2E testing of the feature.

We won't be able to test every config line, simply because we don't have all that HW in our CI pool. However, we should add a test (I propose as a follow-up PR) to ensure consistency between targets listed in the config file, targets available through -fsycl-targets option and targets known to device_architecture extension - all three should "know" the same list of targets.

AlexeySachkov avatar Jul 01 '24 10:07 AlexeySachkov