llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[DeviceSanitizer] Support detecting misaligned access error

Open AllanZyne opened this issue 1 year ago • 1 comments

UR: https://github.com/oneapi-src/unified-runtime/pull/1747

AllanZyne avatar Jun 12 '24 03:06 AllanZyne

@intel/llvm-reviewers-runtime @intel/unified-runtime-reviewers please review. Thank you very much!

AllanZyne avatar Jun 21 '24 08:06 AllanZyne

The failed test "no_sycl_hpp_in_e2e_tests.cpp" is not related to this PR.

AllanZyne avatar Jul 02 '24 06:07 AllanZyne

The failed test "no_sycl_hpp_in_e2e_tests.cpp" is not related to this PR.

Hi @AllanZyne ! It is related. The test makes sure that no E2E tests include <sycl/sycl.hpp>. Instead, the new tests should use <sycl/detail/core.hpp> and similar headers (I suspect you'll also need <sycl/usm.hpp>.)

steffenlarsen avatar Jul 02 '24 06:07 steffenlarsen

The failed test "no_sycl_hpp_in_e2e_tests.cpp" is not related to this PR.

Hi @AllanZyne ! It is related. The test makes sure that no E2E tests include <sycl/sycl.hpp>. Instead, the new tests should use <sycl/detail/core.hpp> and similar headers (I suspect you'll also need <sycl/usm.hpp>.)

Sorry for not checking this. New patch pushed.

AllanZyne avatar Jul 02 '24 06:07 AllanZyne

@intel/unified-runtime-reviewers please review. Thanks.

AllanZyne avatar Jul 04 '24 06:07 AllanZyne

@intel/unified-runtime-reviewers please review. Thank you very much!

AllanZyne avatar Jul 09 '24 11:07 AllanZyne

@intel/unified-runtime-reviewers please review. Thank you very much!

I've added the UR PR to the ready to merge queue. Will get to it soon.

kbenzie avatar Jul 10 '24 09:07 kbenzie

@intel/llvm-gatekeepers please merge

kbenzie avatar Jul 11 '24 19:07 kbenzie