libvpl icon indicating copy to clipboard operation
libvpl copied to clipboard

[legacy-vpp] Support output with MFX_FOURCC_BGR4 format.

Open Austin-Hu opened this issue 3 years ago • 3 comments

Also fixed the issue that redundant pixel(s) would be written to output file, when the input surface isn't aligned with width or height.

Signed-off-by: Austin Hu [email protected]

Austin-Hu avatar Sep 14 '22 16:09 Austin-Hu

Hi @akwrobel, please help review this PR once you'd be available. Thanks!

Austin-Hu avatar Sep 14 '22 16:09 Austin-Hu

Sorry for the delayed reply. We have reviewed your fix and it works. After the change there is no example which uses bgr4 color format, so the code would not be regularly tested. However, it is a good reference for how to work with yet another format and we want to start showing more options.

One request before merging: each example has a util.h file. We want to keep util.h identical for every example. Would you prefer to copy your updated util.h to the other examples and update the PR, or would you rather that we do it?

jeffreymcallister avatar Oct 12 '22 02:10 jeffreymcallister

@jeffreymcallister, the same with PR #67, please help make the change to other util.h files. Thanks!

Austin-Hu avatar Oct 12 '22 17:10 Austin-Hu

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

SupreetSinghPalne avatar Nov 08 '22 20:11 SupreetSinghPalne

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

Austin-Hu avatar Nov 08 '22 21:11 Austin-Hu

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

Oh my bad here is the link - 5f310e9

SupreetSinghPalne avatar Nov 08 '22 21:11 SupreetSinghPalne

Hi Austin, This issue is fixed and merged. Commit ID- 5f310e9

Thanks! Where is the link of that commit? I didn't see the similar change of util.h recently.

Oh my bad here is the link - 5f310e9

Thanks, and it LGTM. Let me close this one.

Austin-Hu avatar Nov 08 '22 21:11 Austin-Hu