libvpl icon indicating copy to clipboard operation
libvpl copied to clipboard

Fixed the issue that redundant pixel(s) would be written to output file.

Open Austin-Hu opened this issue 3 years ago • 3 comments

Fixes Issue #66.

When the bitstream was encoded with width or height aligned.

Signed-off-by: Austin Hu [email protected]

Austin-Hu avatar Sep 07 '22 21:09 Austin-Hu

Hi @jeffreymcallister,

Please help review this PR with Issue #66 if you'd be free.

Thanks!

Austin-Hu avatar Sep 07 '22 21:09 Austin-Hu

Sorry for the delayed reply. We have reviewed your fix and it works. One request before merging though: as you may have seen, each example has a util.h file. We want to keep util.h identical for every example. Would you prefer to copy your fixed util.h to the other examples and update the PR, or would you rather that we do it?

jeffreymcallister avatar Oct 12 '22 01:10 jeffreymcallister

@jeffreymcallister, no worries. Thanks for your review! And could you help make the change to other util.h files and push more commits to this PR? Because definitely you'd have more cases to verify for code quality. Thanks!

Austin-Hu avatar Oct 12 '22 17:10 Austin-Hu

Hi Austine, this issue is fixed and merged. Commit Id - e9990fe

SupreetSinghPalne avatar Nov 08 '22 21:11 SupreetSinghPalne

Hi Austine, this issue is fixed and merged. Commit Id - e9990fe

Thanks! Let me close this PR.

Austin-Hu avatar Nov 08 '22 21:11 Austin-Hu