Mava icon indicating copy to clipboard operation
Mava copied to clipboard

[BUG] Partial dependency in MAVA Redesign

Open AsadJeewa opened this issue 3 years ago • 0 comments

Describe the bug

Cannot import BaseTrainerInit in required_components method ImportError: cannot import name 'BaseTrainerInit' from partially initialized module 'mava.components.jax.training.trainer' (most likely due to a circular import) (/home/asad/Github/mava/mava/components/jax/training/trainer.py

To Reproduce

Steps to reproduce the behavior:

  1. Run any example on develop branch
  2. ImportError: cannot import name 'BaseTrainerInit' from partially initialized module 'mava.components.jax.training.trainer' (most likely due to a circular import) (mava/components/jax/training/trainer.py)

Expected behavior

Imports should not fail and code should run as expected

Context (Environment)

  • Mava develop as of date of issue

Possible Solution

A temporary solution is to import BaseTrainerInit from the init.py file but a better fix is to rework the dependencies

AsadJeewa avatar Aug 15 '22 07:08 AsadJeewa