newforms-bootstrap icon indicating copy to clipboard operation
newforms-bootstrap copied to clipboard

Static display & horizontal against 2.0 [odessyscience version]

Open catskul opened this issue 10 years ago • 5 comments

I took odessyscience's branch and rebased it on 2.0 and fixed one noticed problem.

catskul avatar Sep 26 '15 03:09 catskul

Rendered difference: screenshot from 2015-09-29 23 50 02

catskul avatar Sep 30 '15 03:09 catskul

@seanadkinson any idea why this test might fail/ render the test seen above differently?

catskul avatar Sep 30 '15 03:09 catskul

Hadn't looked at the tests, but it seems like it is rendering extra empty divs.

How did you see the rendered difference? I just see the console output when running npm test.

Might be informative to have bootstrap.css loaded in the rendering, to see if it actually looks correct or not.

seanadkinson avatar Sep 30 '15 05:09 seanadkinson

@seanadkinson I just put both into an empty html document to check the rendering to see if they were functionally equivalent. I'll try again with bootstrap.css loaded.

catskul avatar Sep 30 '15 16:09 catskul

With bootstrap loaded they do look equivalent. So I think I can probably change the test to make it pass.

screenshot from 2015-09-30 12 17 26

catskul avatar Sep 30 '15 16:09 catskul