solid-ui-react icon indicating copy to clipboard operation
solid-ui-react copied to clipboard
verified publisher icon inrupt

React Act warnings in tests

Open Glazy opened this issue 3 years ago • 2 comments

Bug description

Some of the component tests output React act warnings which make the console output messy and could potentially lead to some odd race conditions in tests if left.

To Reproduce

  1. npm run test
  2. Examine console output

Expected result

All tests passing with no console warnings.

Actual result

Tests passing with console warnings.

Additional information

act related warnings are currently present in the following components/hooks:

  • LogoutButton (PR #688)
  • LoginButton
  • useFile

Glazy avatar Oct 08 '22 20:10 Glazy

Hi @Glazy, thanks for raising this, I've raised it internally with the developer tools team at Inrupt, as I know we've some changes under discussion about this SDK and I'd like to clarify those before replying here.

ThisIsMissEm avatar Oct 08 '22 21:10 ThisIsMissEm