solid-style-guide icon indicating copy to clipboard operation
solid-style-guide copied to clipboard

Navbar toolbar items cannot be links

Open Vinnl opened this issue 6 years ago • 1 comments

In the Navigation organism, inside of nav.nav.nav__toolbar, the example uses buttons. However, I think it should be possible to use regular links in there - e.g. to the user's profile. Unfortunately, at this point in time, using an <a> results in the icon not being aligned properly:

image

Vinnl avatar Jun 17 '19 20:06 Vinnl

As a general rule links should navigate to URIs, and buttons should perform an action.

So I agree that we should support buttons and links in the toolbar, so that we have the option to use the appropriate, Semantic HTML element.

megoth avatar Jun 18 '19 14:06 megoth