solid-client-js icon indicating copy to clipboard operation
solid-client-js copied to clipboard

fix: expose parserOptions more

Open ajuvercr opened this issue 1 year ago • 3 comments

This PR fixes #2529.

ajuvercr avatar Oct 15 '24 09:10 ajuvercr

As far as I understand, this does not achieve the intended effect: the introduced ParserOptions from n3 is different from the ParseOptions in the getSolidDataset options (see https://github.com/inrupt/solid-client-js/blob/main/src/resource/solidDataset.ts#L153). This PR adds a new type to the interface, but the passed option will never actually be used, it's just not incompatible with the existing API because it is an additive change.

I think switching to the solid-client ParseOption, and adding that to the API where you were adding ParserOption should get you where you in the right direction.

NSeydoux avatar Oct 21 '24 08:10 NSeydoux

Thanks @NSeydoux for having a look! I totally didn't see the difference between ParseOptions and ParserOptions, it should be all fixed and correct now

ajuvercr avatar Oct 30 '24 17:10 ajuvercr

Could you have another look @NSeydoux ?

ajuvercr avatar Nov 12 '24 13:11 ajuvercr