solid-client-authn-js icon indicating copy to clipboard operation
solid-client-authn-js copied to clipboard

Login and Logout handler

Open zg009 opened this issue 1 year ago • 2 comments

New feature description

Addresses https://github.com/inrupt/solid-client-authn-js/issues/422 The simplest approach was to add an entirely new EVENTS const which is simply emitted at all locations along with the login and logout existing events. I was unable to run the E2E tests, I figure it was due to the confusion on provisioning the pod base uri. I added unit tests which passed under Jest, and conformed to the existing test structure. The commit messages could be improved upon. I can create a new fork if needed.

Checklist

  • [?] All acceptance criteria are met.
  • [X] Relevant documentation, if any, has been written/updated.
  • [x] The changelog has been updated, if applicable.
  • [X] New functions/types have been exported in index.ts, if applicable.
  • [x] Commits in this PR are minimal and have descriptive commit messages.

zg009 avatar Feb 22 '24 05:02 zg009

Someone is attempting to deploy a commit to the Inrupt Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 22 '24 05:02 vercel[bot]

I do not know how to add a changelog entry, sorry. I am also unsure what configs are conflicting in the e2e-test file

zg009 avatar Apr 25 '24 21:04 zg009