cardano-node icon indicating copy to clipboard operation
cardano-node copied to clipboard
verified publisher icon input-output-hk

tx-generator: Merge reusable code with Cardano.API.IPC

Open MarcFontaine opened this issue 4 years ago • 4 comments

There is some code duplication in Cardano.API.IPC /Cardano.API.InMode and Cardano.Benchmarking.GeneratorTx.SubmissionClient. In particular the conversion functions between API types and Consensus types.

MarcFontaine avatar Apr 29 '22 11:04 MarcFontaine

This overlaps with https://github.com/input-output-hk/cardano-node/issues/3770 This needs an extension of cardano-api/coordination with cardano-api maintainers

MarcFontaine avatar May 17 '22 07:05 MarcFontaine

This has been done for toConsensusGenTx which is now exported from Cardano.Api. An other candidate is fromGenTxId :: GenTxId CardanoBlock -> TxId It may also make sense to use TxInMode consistently throughout the tx-generator

MarcFontaine avatar May 31 '22 09:05 MarcFontaine

Is there any more code exposed (or exposable) in the API that is currently duplicated in the generator?

mgmeier avatar Oct 07 '22 13:10 mgmeier

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

github-actions[bot] avatar Oct 14 '25 02:10 github-actions[bot]