modularity icon indicating copy to clipboard operation
modularity copied to clipboard

Remove support for deprecated default modules

Open tfrommen opened this issue 1 year ago • 0 comments

Please check if the PR fulfills these requirements

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a follow-up (alternative) to #53.

Currently, this code results in failing tests. However, there was also a bug in the test logic, masking other issues. Considering that there was no change to production, except for the removal of default module handling in boot, I would argue that the expectations in some failing tests are incorrect, and should be reviewed and fixed.

What is the current behavior? (You can also link to an open issue here)

Default modules passed to the boot method are being handled.

What is the new behavior (if this is a feature change)?

The boot method does no longer support passing default modules.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

tfrommen avatar Jan 27 '25 15:01 tfrommen