hermes icon indicating copy to clipboard operation
hermes copied to clipboard

Useless NewBlock events sent to connection and channel workers

Open ancazamfir opened this issue 3 years ago • 0 comments

Summary of Bug

I believe that connection and channel handshake workers do not need the NewBlock events. The supervisor scans for unfinished handshakes and spawns a worker for each one. The worker itself should just act on connection or channel IBC events depending on the worker type. Currently during handshake, on each new block event the worker performs some useless queries just to find out that there is no work to be done.

Version

all

Steps to Reproduce

  • start two chains
  • hermes --config psql_no.toml create channel --a-chain ibc-0 --b-chain ibc-1 --a-port transfer --b-port transfer --new-client-connection --yes
  • hermes start
  • check the logs and metrics (starts processing block event in the logs with no constructive action, queries in metrics, e.g. query_client_connections, query_connection, etc)

Acceptance Criteria


For Admin Use

  • [x] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate milestone (priority) applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

ancazamfir avatar Jul 29 '22 21:07 ancazamfir