infobip-api-java-client icon indicating copy to clipboard operation
infobip-api-java-client copied to clipboard
verified publisher icon infobip

Build, Publish script update, added git hook for code formatting.

Open ib-tjuhasz opened this issue 2 years ago • 6 comments

  • Added github workflow/pipeline script for publishing to public Maven artifactory - maven-publish.yml
  • Added Snyk coverage step to build pipeline
  • Added git hook pre-commit script - mvn spotless:apply
  • Added maven plugin to support git hooks. git-build-hook-maven-plugin
  • Bumped slf4j-api version to 2.0.7
  • Bumped jackson version to 2.15.2

ib-tjuhasz avatar Jul 07 '23 12:07 ib-tjuhasz

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot] avatar Jul 07 '23 12:07 github-advanced-security[bot]

@ukmadlz

ib-tjuhasz avatar Jul 12 '23 11:07 ib-tjuhasz

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 13 '23 13:07 sonarqubecloud[bot]

Let's reorganize git commits a bit.

ib-fsrnec avatar Aug 08 '23 12:08 ib-fsrnec

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 19 '23 07:09 sonarqubecloud[bot]

[like] Ildar Asmandiyarov reacted to your message:

[cid:Infobip_logo_vertical_signature_e28e13d2-255b-4571-a70c-8292f2d75c0b.png]

Ildar Asmandiyarov

Senior DevOps Engineer

E @.***

M

A Istarska ul. 157, 52215 Vodnjan, Croatia

www.infobip.comhttp://www.infobip.com

From: Mike Elsmore @.> Sent: Tuesday, October 10, 2023 7:22:16 PM To: infobip/infobip-api-java-client @.> Cc: Subscribed @.***> Subject: [EXTERNAL] Re: [infobip/infobip-api-java-client] Build, Publish script update, added git hook for code formatting. (PR #25)

@ukmadlz requested changes on this pull request.

In the maven.yml workflow, as the jobs are independent of each other they should be separate workflows. Eg, sonar.yml & snyk.yml

— Reply to this email directly, view it on GitHubhttps://github.com/infobip/infobip-api-java-client/pull/25#pullrequestreview-1668718971, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALI4DZY2YNOJMPU32T5CLDX6WN6RAVCNFSM6AAAAAA2BYIIAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRYG4YTQOJXGE. You are receiving this because you are subscribed to this thread.Message ID: @.***>

infobip-ci avatar Oct 11 '23 05:10 infobip-ci