giraffe icon indicating copy to clipboard operation
giraffe copied to clipboard

Customization / clean up of units

Open hoorayimhelping opened this issue 5 years ago • 2 comments

Background

There's currently limited ability to change the units on a graph. There are three choices (none, si, binary) with some prefix or suffix label options. We want to give users more control of the units.

Additional options

  • Comma separation
    • if true separate every third character with a comma starting from the beginning of the string
    • Essentially turns 1000 into 1,000
  • Unit scale & Suffix/Prefix scale
    • Different than y axis scale
    • User would specify an array of when to "scale" up the unit by entering comma separated values instead of a single value
    • For example, a time unit scale would be [0,60, 60, 24, 30]. You could match unit scale to suffix scale [s,m,h,d,mo]
    • Another example would be bits:
      • unit scale: [0, 1024, 1024, 1024, 1024]
      • suffix scale: [b, Kb, Mb, Gb, Tb]

Presets

  • Once the above options are implemented we can also implement unit presets, which represent common combinations of options for specific units
  • Example:
    • $USD
      • 2 decimal points
      • comma separation true
      • prefix with $
      • unit scale with [0,1000,1000,1000,1000]
      • suffix scale with [,,M,B,T] (first two are blank)
    • Bytes
      • 2 decimal points
      • unit scale with [0,1024,1024,1024,1024]
      • suffix scale with [b,Kb,Mb,Gb,Tb,Pb]

hoorayimhelping avatar Oct 29 '20 22:10 hoorayimhelping

@alexpaxton and @russorat please go over this.

121watts avatar Nov 02 '20 18:11 121watts

This issue is a proof of concept for some of these ideas in giraffe https://github.com/influxdata/giraffe/pull/580

If we want to see this work fully it will take more time than we are currently willing to dedicate to it.

zoesteinkamp avatar Jun 10 '21 17:06 zoesteinkamp