flux icon indicating copy to clipboard operation
flux copied to clipboard

Refactor commented out test cases in the interpreter to work with new interface

Open jpacik opened this issue 7 years ago • 4 comments

A group of test cases has been commented out in interpreter/package_test.go due to an interface change on the interpreter. The tests need to be refactored to work with the new interface.

jpacik avatar Jan 10 '19 18:01 jpacik

@jlapacik Is this still an issue? Or can we close it?

nathanielc avatar Jul 03 '19 20:07 nathanielc

@nathanielc I think we can close this issue. There are still some commented out test cases that need to be reworked due to the interpreter interface changing a while back. But we have pretty good test coverage as is (not including the ones that are commented out).

What do you think?

jpacik avatar Jul 03 '19 20:07 jpacik

Let's delete the tests then, instead of leaving them commented out.

nathanielc avatar Jul 09 '19 22:07 nathanielc

This issue has had no recent activity and will be closed soon.

github-actions[bot] avatar Sep 22 '24 01:09 github-actions[bot]