node-bindgen icon indicating copy to clipboard operation
node-bindgen copied to clipboard

Support nodejs-mobile in nj-cli build

Open staltz opened this issue 4 years ago • 3 comments

With a few tweaks, node-bindgen actually supports iOS and Android via nodejs-mobile.

I don't have time available and knowledge of this codebase enough to submit a PR, but if you (maintainers) want to support nodejs-mobile, then it's a low-hanging fruit since you can just follow the steps I implemented here:

https://github.com/ssb-ngi-pointer/ssb-validate2-rsjs-node/blob/289a6bd92d651d6d97cf07f89d6325ba82686d80/install.js#L33-L44

Thanks for node-bindgen!

staltz avatar Jun 07 '21 10:06 staltz

Great. We will certainly take look at support mobile OS. @simlay What do you think?

sehz avatar Jun 07 '21 23:06 sehz

This looks deceptively simple. I don't have much time on my hands either, but I would also want this implemented. @staltz do you know of a good testing PoC to verify things work correctly?

mkawalec avatar Jun 16 '21 18:06 mkawalec

@mkawalec Unfortunately I don't have a simple setup to recommend, but I maintain manyverse which uses node-bindgen (indirectly) in the branch validate2.

To keep it easy for you, I suggest you just try coding the changes in node-bindgen on a separate branch (of node-bindgen) and then you can ask me to test it out. I can just point my dependencies to your git branch of node-bindgen.

staltz avatar Jun 16 '21 18:06 staltz