fix: enable strict mode for TS types

Open crutchcorn opened this issue 1 year ago • 2 comments

Please verify the following:

[x] yarn build-and-test:local passes
[x] I have added tests for any new features, if relevant
[x] README.md (or relevant documentation) has been updated with your changes

Describe your PR

This PR enables strict mode for the reactotron-core-client codebase to fix issues documented here:

https://github.com/infinitered/reactotron/issues/1430

Apr 02 '24 23:04 crutchcorn

Is there anything that needs to be done to move forward with this PR?

I'm trying to upgrade our large app to RN 0.74 and that uses TypeScript 5, at which point there's no way out of type checking imported .ts dependencies.

Because reactotron-react-native is importing reactotron-core-client from src .ts files, rather than compiled .js I cannot find a way to disable these checks (require hack in the linked issue does not work for our setup).

I'd be happy to help if we could get a version released that works with latest RN versions, given Flipper is removed in those versions Reactotron is more needed than ever. :smile:

Jul 24 '24 16:07 markwilcox