react-native-mlkit icon indicating copy to clipboard operation
react-native-mlkit copied to clipboard

fix(web): do not throw error on module init

Open younes0 opened this issue 1 year ago • 1 comments

This PR uses face-detection module to showcase how we can handle Web by ignoring the module and throwing an error when trying to use hooks.

younes0 avatar Aug 01 '24 09:08 younes0

🦋 Changeset detected

Latest commit: d8fbb870746ca2b9da28bb0650613641d765922b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@infinitered/react-native-mlkit-face-detection Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 01 '24 09:08 changeset-bot[bot]

I really like this approach -- going to work on implementing this for the rest of the modules today.

trevor-coleman avatar Feb 04 '25 15:02 trevor-coleman

@cdanwards implemented this pattern in all packages in in #205, so I'm going to close this PR but with much appreciation for the contribution!

trevor-coleman avatar Feb 18 '25 17:02 trevor-coleman

@all-contributors please add younes0 for ideas

trevor-coleman avatar Feb 18 '25 17:02 trevor-coleman

@trevor-coleman

I've put up a pull request to add @younes0! :tada:

allcontributors[bot] avatar Feb 18 '25 17:02 allcontributors[bot]