Missing support for package name

[jasongaare]

Issue

When the package name is not equivalent to com.[appDisplayName], paths to android native files are incorrect

How upgrade helper handles it

React Native Upgrade Helper supports two inputs:

1. App Name
2. Package Name

Actual Result with Flame

Best I can tell, the code found here here (which is replacing RNDiff with the app name) is missing package name support for situation like this

This results in "File Not Found" errors, because the file path is incorrectly constructed

↠ Skipping: ./android/app/src/main/java/com/companycam/MainActivity.java (file not found)

Expected Result with Flame

we'd replace "com.rndiff" with package name "com.agilx.companycam"

■ File:   ./android/app/src/main/java/com/agilx/companycam/MainActivity.java

Upgrade Helper diff: ...

I'd love to take a look at this soon-ish to see if there's a quick solution. Maybe a field in app.json for a package name?

[jamonholmgren]

@jasongaare Yeah, good point. I'd like to make Flame much more resilient to files not being in predictable places, in general.

Would love some help with this!

[huyvovan0510]

I am also facing this issue, and the workaround is to change the displayName in the app.json file to allow Flame AI to follow the path. In your case, just change displayName to "displayName": "agilx/companycam". I hope this will help you solve this issue, @jasongaare.