inducer
OctaveCodeQuestion redux
This PR is a clean new build of OCQ on up-to-date RELATE. This will replace #633
The major piece missing as of now is a good set of unit tests. Does the CI know to pull a new Docker image davis68/relate-octave?
The major piece missing as of now is a good set of unit tests. Does the CI know to pull a new Docker image davis68/relate-octave?
You can just add a docker pull bit to the CI script.
To cut down on noise in my email, I'm unsubscribing from this PR. When it next needs my attention, please @-mention me or hit the "request review" button. Otherwise, I may not see your messages in a timely manner.
@inducer OK, this OctaveCodeQuestion seems to work in our basic testing. Please review and let us know. We used the test markdowns in test_code.py on the sandbox page to test robustness of the OCQ evaluation.
Thanks to @karthiksharma98 for testing with me.
BEFORE MERGING I need to revert a couple of local settings that are swept up in here but those are minor.
@davis68 There seem to be quite a few CI failures still, and these need to be fixed before merging. Would you be able to address those?
@inducer, @karthiksharma98 and I have handled all of the linting and basic unit tests issues. Now there's a slew of connection-related issues on the page tests. Can you advise on those? These may be Docker/CI—I set it to pull davis68/relate-octave but it could be from that failing. (Local Docker is on the fritz, currently hacking on it.)
An easy way to see what's going on in an actions run is to (temporarily) include this action in the failing job steps list in .github/workflows/ci.yml. Then you can SSH in and poke around to see why things are failing.
I can see that no (?) Docker containers are starting and staying running for either Python or Octave. Since we didn't touch Python I have no idea why that would be the case.
@inducer Can you advise on this? We're able to get the markdowns in markdowns.py to work in the page sandbox on a local RELATE installation, but for CI it doesn't seem to work.
