Added JupterNotebookUploadQuestion.
Fix #690
Codecov Report
Merging #701 into master will increase coverage by
0.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 96.82% 96.84% +0.02%
==========================================
Files 45 45
Lines 11169 11245 +76
Branches 2058 2065 +7
==========================================
+ Hits 10814 10890 +76
Misses 294 294
Partials 61 61
| Impacted Files | Coverage Δ | |
|---|---|---|
| course/page/__init__.py | 100.00% <100.00%> (ø) |
|
| course/page/upload.py | 100.00% <100.00%> (ø) |
|
| course/utils.py | 99.33% <100.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a89c621...d7b2974. Read the comment docs.
Here's a pretty important question that occurred to me: Can you find/add a link in source to nbconvert's policy on whether it's designed to be safe with untrusted input?
Here's a pretty important question that occurred to me: Can you find/add a link in source to nbconvert's policy on whether it's designed to be safe with untrusted input?
I'll looking into that. At least, I found the notebook have the ability to execute Javascript scripts. I don't know whether that's still the case when its converted to html. That might be an issue before we can merge this PR.
@inducer https://jupyter-notebook.readthedocs.io/en/stable/security.html#security-in-notebook-documents That's the documentation about the security of notebook itself. I didn't found the docs for nbconvert.
There's a sanitize preprocessor, we need to make sure the preprocessor is included when we do the convert.