Only mark flow grade unavailble upon unavailable page grade if page c…

[inducer]

…arries value

[inducer]

@dzhuang Based on the test failures, this seems to go directly against your expectations. Could you explain?

[dzhuang]

Sorry for being late.

The broken test cases are testing that, when a page had been previously graded, and then a grader removed the grade (by submitting the human grading form with points field empty), the grading status of the page is then "None".

Your changes made that impossible, and grade those pages with 0 points instead.

[codecov[bot]]

Codecov Report

Merging #622 into master will decrease coverage by <.01%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   96.93%   96.92%   -0.01%     
==========================================
  Files          45       45              
  Lines       11096    11097       +1     
  Branches     2062     2063       +1     
==========================================
  Hits        10756    10756              
  Misses        292      292              
- Partials       48       49       +1

Impacted Files	Coverage Δ
course/flow.py	99.1% <50%> (-0.09%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e5b6c3...e20cfb5. Read the comment docs.

[inducer]

Good catch. My previous logic was flipped. How about now?

[dzhuang]

I think that's ok now. I'm wondering when that will happen? (for writing tests).

[inducer]

I'm wondering when that will happen? (for writing tests).

The situation where it arose for me was where there was an optional, human-graded question in the flow, and some students submitted something. They weren't shown a grade their final grade for really no good reason.

Btw, thanks for thinking about the testing angle. Should I wait with merging this until we have tests?

[dzhuang]

Then this issue is related to #623? If yes, there might be a problem, from the perspective of graders, how can a grader identify and find ungraded optional pages? Currently, my asistants identify those pages by looking for flows which had not generated grades.

[inducer]

how can a grader identify and find ungraded optional pages?

I think that clicking "view page grades" in the "grading opportunity" view should show grades for all pages and all students.