relate Migration to Bootstrap 4?

Hi, I was wondering if you were looking to migrate over to Bootstrap 4 now that it's not in alpha/beta anymore. I saw that CRISPY_TEMPLATE_PACK is using bootstrap3 and it looks like it would be straightforward to upgrade. But I'm not sure if there's compatibility issues in terms of styling.

Sep 13 '18 06:09 josh-byster

This should definitely happen. One potential issue is that references to Bootstrap 3 styling have "leaked" into course content on our end. So from my perspective, it would be the most convenient to make this transition (i.e. merge a relevant PR) at a semester boundary, i.e. at the end of the year or over the summer, so as to not randomly make course content look less pretty randomly in the middle of the semester.

cc @davis68 @dzhuang @lukeolson -- opinions?

Sep 13 '18 14:09 inducer

Here is the change log for quick reference. https://getbootstrap.com/docs/4.0/migration/

Notably, buttons need %s/btn-default/btn-secondary/g. Input forms have some changes as well.

My custom CSS will need some minor changes to class names to be compliant, but no major shovel work.

Sep 13 '18 15:09 davis68

A PR is welcome, and I agree warnings that the migation for instances and clearing page caches should be done between semester are needed.

Sep 17 '18 01:09 dzhuang

fwiw, I've gotten 101 ready for this transition now. (fingers crossed)

Jan 10 '19 17:01 davis68

It's been a while, but #892 (which is pretty close to done) should get us onto Bootstrap 5.

Feb 28 '22 06:02 inducer

I'm ok with it. My fork is more than 100 commit behind yours, and I'll find time to catch up.

Feb 28 '22 07:02 dzhuang