pudb icon indicating copy to clipboard operation
pudb copied to clipboard

default urwid bright-is-bold false

Open ghost opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I've noticed urwid looks strange since I've started using "kitty" terminal. kitty comes with its own custom termaps, and so it's necessary to set TERM=kitty. In urwid, rather than using termap, they use a simple "not xterm" heuristic for their "bright is bold" flag. This results in a random half of all syntax becoming bold.

https://github.com/urwid/urwid/blob/master/urwid/raw_display.py#L79

Describe the solution you'd like A clear and concise description of what you want to happen.

Could we call set_terminal_properties(bright_is_bold=False) during startup? If you want to get fancy we could determine this boolean via termcap (as urwid should have done).

ghost avatar Dec 30 '22 22:12 ghost

I use kitty as well, and I've never noticed anything looking off.

  • What's the chance of set_terminal_properties(bright_is_bold=False) breaking something else?
  • Do you have a sense what the correct termcap query might look like?

inducer avatar Jan 01 '23 02:01 inducer