meshmode icon indicating copy to clipboard operation
meshmode copied to clipboard

Fix warnings and deprecations

Open alexfikl opened this issue 1 year ago • 1 comments

There's still a bunch of warnings about SVM memory like

<generated code for 'invoke_frozen_nodes1_2d_loopy_kernel'>:131: InconsistentOpenCLQueueWarning: Array has different queue from backing SVM memory. This may lead to the array getting deallocated sooner than expected, potentially leading to crashes.

and some more loopy warnings, but everything else should be clean.

alexfikl avatar Apr 28 '24 19:04 alexfikl

@inducer From what I can tell, the failed test is due to the fact that the mesh isn't checked on replace, i.e.

  • Before, calling Mesh(...) would run the checks and calling mesh.copy(...) would also run the checks.
  • Now, calling calling make_mesh(...) runs the checks, but running replace(mesh, ...) does not run the checks. (this makes sense to me)

Does that mean that every Mesh.copy should be replaced with a replace + assert is_mesh_consistent(...)?

EDIT: https://github.com/inducer/meshmode/compare/405a6bf3c3f11460420b702a6c6bcb8c895d060d..9ec01ac324deb4237ef0128e9c5159596f55f9b0 should hopefully fix the failed test.

alexfikl avatar Apr 29 '24 06:04 alexfikl

Thx!

inducer avatar May 08 '24 22:05 inducer