Andreas Klöckner comments

Results 957 comments of


                                            Andreas Klöckner

Fix CInstruction in calculating mem access map.

This ultimately did go in as #765, albeit without the requested safeguards. Not the end of the world, I guess.

use conda for intel ocl ci

We're up to https://github.com/intel/llvm/issues/7877. :slightly_smiling_face:

isl hashes and equality do not consider names

Looks like the full impact of this was masked by https://github.com/inducer/islpy/issues/102. See https://github.com/inducer/islpy/pull/103 for more context.

isl hashes and equality do not consider names

Responding to @kaushikcfd from https://github.com/inducer/islpy/pull/103: > I was thinking I could make a quick PR to loopy which would also add the condition `bkt_set.get_var_dict() == set_.get_var_dict()`, but the problem is...

Pickling/unpickling a dtype resets isbuiltin flag

Note that this also appears to change the hash of the dtype, post-unpickling.

Pickling/unpickling a dtype resets isbuiltin flag

Still in 1.10.4.

Must not use Pybind's implicit object-identity `hash`

Does `__hash__` have documented cross-run semantics?

Must not use Pybind's implicit object-identity `hash`

But then something's weird. `set_get_hash` is a direct wrapper of `isl_set_get_hash`: ```c uint32_t set_get_hash(set const &arg_self) { isl_ctx *islpy_ctx = nullptr; if (!arg_self.is_valid()) throw isl::error( "passed invalid arg to isl_set_get_hash...

Must not use Pybind's implicit object-identity `hash`

See #103 for a first stab. I'm excited for all the ways in which this breaks loopy. :slightly_smiling_face:

Fix GNU statement expression syntax and code generation

Thanks! Could you add a test?