react-native-map-link icon indicating copy to clipboard operation
react-native-map-link copied to clipboard

Passing sourceLatitude/sourceLongitude as undefined breaks the path

Open vvscode opened this issue 4 years ago • 3 comments

At the https://github.com/flexible-agency/react-native-map-link/blob/master/src/index.js#L42

we verify if params are in the options, but do not check the value, so for undefined we have

parseFloat(undefined); // NaN

for sure it can be fixed in the client code, but seems like nice to handle it inside the lib

image

vvscode avatar Mar 31 '21 08:03 vvscode

If this is so that you can open a single place in google maps, rather than directions to that place, see my patch

theneekz avatar Sep 28 '21 19:09 theneekz

@theneekz PR is welcome

vvscode avatar Sep 28 '21 21:09 vvscode

pr submitted

theneekz avatar Oct 06 '21 01:10 theneekz