react-native-email-link icon indicating copy to clipboard operation
react-native-email-link copied to clipboard
verified publisher icon includable

Encode subject

Open fansilva1991 opened this issue 2 years ago • 2 comments

Description

This PR adds the ability to apply encodeURIComponent to the subject.

Related to issue:

https://github.com/includable/react-native-email-link/issues/118

fansilva1991 avatar Aug 07 '23 00:08 fansilva1991

Thanks for opening this!

Shouldn't we make this a default behaviour for the particular situation addressed in #118? E.g. always URL-encode when on iOS and the default client is selected?

Of course that is a breaking change, but I'm happy to release that as a v2 of the library, together with some other cleanup.

tschoffelen avatar Aug 07 '23 08:08 tschoffelen

Shouldn't we add this prop (encodeSubject) also to the ComposeOptions type defined in the index.d.ts. encodeBody is also missing.

hazyikmis avatar Aug 09 '23 15:08 hazyikmis