Make view of FormController available in *RenderViewEvents

[haraldwitt]

This resolves issue: https://github.com/in2code-de/powermail/issues/1053

[haraldwitt]

The update of VariablesViewHelper.php solves issue https://github.com/in2code-de/powermail/issues/1061

[mschwemer]

Hi Harald

Thanks for your pull request and your efforts.

Since the method signature of the event is public api, I cannot add it this way. These changes are breaking. The next breaking changes will be with the TYPO3 v13 compatible version.

If you can make it non-braking, I will have another look.

Non-breaking means:

• move the new argument to the end of the method signature
• make the argument optional

Marcus

[haraldwitt]

Hi Marcus

Yes you are right. In general it would be breaking if some third party would make an instance of these events. But I'ts the sense of the events to avoid exactly this. The third party should always use EventListeners and the getters and setters of the event.

But it doesn't hurt. I'll make this non-breaking.

Harald

[rupasix]

I've used those changes to fix error with f:cObject in plugin's thx.body and it worked.

[haraldwitt]

That's fine. For the problem with f:cObject this change would have been enough: https://github.com/in2code-de/powermail/pull/1054/commits/c826abd93cf51dac798d837096d9a70bf3e77d24

All other changes are new features

[kitzberger]

@haraldwitt, thanks for your patch! Working just fine ;-)

[mschwemer]

@haraldwitt sorry for bothering you again

I tested the branch and 36 of 95 behaviour tests are failing. I will not merge this as is.

Furthermore about your comment in https://github.com/in2code-de/powermail/pull/1054#issuecomment-2232883685 I would prefer to split features and bugfixes into separate PRs.

TIA