immer icon indicating copy to clipboard operation
immer copied to clipboard
verified publisher icon immerjs

Add failing test for nested and chained produce calls

Open jpallen opened this issue 3 years ago • 1 comments

jpallen avatar May 10 '22 11:05 jpallen

Deploy Preview for quizzical-lovelace-dcbd6a canceled.

Name Link
Latest commit 4f77f40401173081a7ac02a98afcd491eafb1415
Latest deploy log https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/627ac4ff8cdc4100095cf518

netlify[bot] avatar May 10 '22 11:05 netlify[bot]

Putting on hold for now, as the test looks legit but contrived, so some context on the original problem this is addressing would be needed to be able to figure this one out.

mweststrate avatar Jan 15 '23 16:01 mweststrate

Ah, this might relate to #917, will check on top of that

mweststrate avatar Jan 15 '23 16:01 mweststrate

Thanks for looking at this. This test is capturing the bug I described in https://github.com/immerjs/immer/issues/936, which has a bit more context as to what conditions triggered this error.

jpallen avatar Jan 15 '23 16:01 jpallen

NOTE: will merge this diff, which will break main, but otherwise I have to cherrypick the test and the original attribution to @jpallen would be lost :)

mweststrate avatar Jan 15 '23 17:01 mweststrate

:tada: This PR is included in version 9.0.19 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jan 27 '23 14:01 github-actions[bot]