imgproxy-helm icon indicating copy to clipboard operation
imgproxy-helm copied to clipboard
verified publisher icon imgproxy

Pass SecurityContext for container from values

Open SimonWoidig opened this issue 7 months ago • 1 comments

Fixes #200

SimonWoidig avatar Jun 09 '25 13:06 SimonWoidig

I don't want to rush anyone, but the PR is ready I think and there are not that many changes. Would appreciate if anyone looked at it. Thank you!

SimonWoidig avatar Jul 02 '25 06:07 SimonWoidig

@DarthSim

C4tWithShell avatar Sep 18 '25 00:09 C4tWithShell

Awesome. Could you please mention containerSecurityContext field in the README? Besides that, looks good for me. @SimonWoidig

gzigzigzeo avatar Sep 24 '25 14:09 gzigzigzeo

Awesome. Could you please mention containerSecurityContext field in the README? Besides that, looks good for me. @SimonWoidig

Will do!

SimonWoidig avatar Sep 24 '25 14:09 SimonWoidig

Sorry for the noise, but I've updated the readme. The description for the pod securityContext didn't make much sense to me but I didn't change it. For the containerSecurityContext I have added a bit different description with a link to the K8s docs. If you want, I can also change the securityContext to be more similar or vice versa (the containerSecurityContext).

SimonWoidig avatar Sep 24 '25 14:09 SimonWoidig

Thank you. We have #198, which addresses the same issue. It renames securityContext to podSecurityContext which is much more logical - but breaks backward compatibility at the same time. I am going to merge your PR, and then will add podSecurityContext as an alias for securityContext (or vice versa) in the separate PR.

gzigzigzeo avatar Sep 24 '25 15:09 gzigzigzeo