imagej-ops icon indicating copy to clipboard operation
imagej-ops copied to clipboard

Improve FeatureSet Tests

Open tibuch opened this issue 9 years ago • 5 comments

Test and improve FeatureSets.

  • [x] 2D Geometric
  • [x] 3D Geometric
  • [x] Statistic
  • [x] Haralick
  • [x] Tamura 2D (already has tests)
  • [x] Zernike
  • [x] Histogram (already has tests)
  • [ ] ImageMoments (https://github.com/imagej/imagej-ops/pull/301)
  • [ ] Pixel based geometric features

tibuch avatar Sep 23 '16 13:09 tibuch

@ctrueden and @dietzc why do we have expensive geom tests and normal ones?

tibuch avatar Sep 26 '16 14:09 tibuch

I think for historical reasons. If you find "normal" ones which cover all the cases, it's absolutely OK.

dietzc avatar Sep 26 '16 14:09 dietzc

@tibuch I thought you were the one who authored those expensive tests! No?

I would much rather have only fast-running tests but which still exercise the algorithms sufficiently. But my understanding was that someone (you? someone else?) thought the small ones might not be rich/complex enough to fully exercise the algorithms?

ctrueden avatar Sep 26 '16 16:09 ctrueden

@ctrueden I guess the tests were added by @seebacherd.

I will replace the images by smaller but complexer (curves, holes and so on) ones.

I would say the accuracy of the tests depends a lot more on small epsilons.

tibuch avatar Sep 26 '16 17:09 tibuch

@tibuch Thanks, sounds great!

ctrueden avatar Sep 26 '16 18:09 ctrueden