fl_chart icon indicating copy to clipboard operation
fl_chart copied to clipboard

Giving users control over min/maxIncluded for axis titles by including them into SideTitles (addresses #906)

Open sczesla opened this issue 1 year ago • 2 comments

Including titles (labels) for the minimum and maximum data value is sometimes not desirable (see #906). The iterateThroughAxis routine (in axis_chart_helpers.dart) provides the logic for optional inclusion of the minimum and maximum already. This PR gives users control over these flags by incorporating them into SideTitles.

sczesla avatar Jun 17 '24 13:06 sczesla

You haven't used the properties that you defined. I think you need to add them here. Also, please read the contribution guideline carefully, you need to write unit-tests

imaNNeo avatar Jun 21 '24 15:06 imaNNeo

Thanks for the feedback!

You haven't used the properties that you defined. I think you need to add them here.

I don't think so. Your link points to the defaults. The values are being used, possibly overwriting those defaults , when iterateThroughAxis is called here

Also, please read the contribution guideline carefully, you need to write unit-tests

Right. I added a test of the effect of setting the parameters when plotting, fixed formatting issues, edited the CHANGELOG, and rebased.

Cheers

sczesla avatar Jun 25 '24 10:06 sczesla

Thank you so much for your contribution!

imaNNeo avatar Aug 26 '24 22:08 imaNNeo