java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Update BallThreadTest.java

Open Aariyan007 opened this issue 4 months ago • 4 comments

What does this PR do?

This PR resolves Spotless code formatting violations that were causing Maven build failures in the twin module.

Fixes #3303

Changes made:

  • Restored required imports for ArgumentMatchers.any and ArgumentMatchers.eq that are used in the testInterrupt() method
  • Fixed import ordering to follow alphabetical convention as enforced by Spotless
  • Added proper spacing between import statements and class declaration
  • Removed commented-out import statements to clean up the code

Root cause: The original issue was caused by unused imports that were commented out, but the code still referenced eq() and any() methods in the test. This created a mismatch between what was imported and what was actually used, triggering Spotless formatting violations.

Testing:

  • [x] Build passes locally with mvn clean compile
  • [x] Spotless check passes with mvn spotless:check
  • [x] All existing tests continue to pass
  • [x] Verified fix resolves the specific Maven build failure mentioned in #3303

This change ensures the codebase maintains consistent formatting standards while preserving all test functionality.

Aariyan007 avatar Sep 10 '25 05:09 Aariyan007

PR Summary

This PR fixes Spotless code formatting violations in the BallThreadTest.java file, resolving a Maven build failure. The changes include restoring required imports, fixing import ordering, adding spacing between imports and the class declaration, and removing commented-out imports.

Changes

File Summary
twin/src/test/java/com/iluwatar/twin/BallThreadTest.java Fixed Spotless code formatting violations. Restored imports for ArgumentMatchers.any and ArgumentMatchers.eq. Fixed import order and spacing. Removed commented-out imports.

autogenerated by presubmit.ai

github-actions[bot] avatar Sep 10 '25 05:09 github-actions[bot]

The original issue was caused by unused imports that were commented out, but the code still referenced eq() and any() methods in the test. This created a mismatch between what was imported and what was actually used, triggering Spotless formatting violations. Now its Fixed

Aariyan007 avatar Sep 10 '25 15:09 Aariyan007

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Nov 12 '25 02:11 github-actions[bot]