java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard
verified publisher icon iluwatar

Dep: remove mongodb uber artifact

Open robertvolkmann opened this issue 3 years ago • 4 comments

spring-boot-dependencies already provides the same artifacts as org.mongodb.mongo-java-driver.

robertvolkmann avatar Nov 20 '22 20:11 robertvolkmann

@iluwatar Why are the tests MongoBankTest, MongoTicketRepositoryTest, and MongoEventLogTest disabled? What about using an embedded Mongo database or mocking the MongoClient?

robertvolkmann avatar Nov 20 '22 21:11 robertvolkmann

spring-boot-dependencies already provides the same artifacts as org.mongodb.mongo-java-driver.

Ok, in that case this is a good technical improvement to remove the duplication

iluwatar avatar Nov 30 '22 16:11 iluwatar

@iluwatar Why are the tests MongoBankTest, MongoTicketRepositoryTest, and MongoEventLogTest disabled? What about using an embedded Mongo database or mocking the MongoClient?

I suppose the tests need a real MongoDB installed before they can run. What you suggest sounds like a good way forward. I'll create a new ticket about it.

iluwatar avatar Nov 30 '22 16:11 iluwatar

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 30 '22 19:11 sonarqubecloud[bot]

Looks good! Thank you for the contribution 🎉

iluwatar avatar Dec 04 '22 08:12 iluwatar