java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Refactor unit tests without depending on Guava

Open kongleong86 opened this issue 3 years ago • 3 comments

Refactor unit tests without depending on Guava external library

  • Using less libraries to do unit tests will help on code maintainability and future libraries upgrade.

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

kongleong86 avatar Oct 26 '22 22:10 kongleong86

@kongleong86 Your branch has conflicts. Could you resolve them?

robertvolkmann avatar Nov 20 '22 19:11 robertvolkmann

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 01 '22 18:12 sonarqubecloud[bot]

Please resolve the conflicts and we can proceed with the merge

Conflicts resolved.

kongleong86 avatar Dec 03 '22 16:12 kongleong86

@iluwatar could you please merge? It would simplify #2357.

robertvolkmann avatar Dec 04 '22 09:12 robertvolkmann

Looks good! Thank you for the contribution 🎉

@all-contributors please add @kongleong86 for code

iluwatar avatar Dec 04 '22 09:12 iluwatar

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

@kongleong86 already contributed before to code

allcontributors[bot] avatar Dec 04 '22 09:12 allcontributors[bot]

@all-contributors please add @robertvolkmann for review

iluwatar avatar Dec 04 '22 09:12 iluwatar

@iluwatar

@robertvolkmann already contributed before to review

allcontributors[bot] avatar Dec 04 '22 09:12 allcontributors[bot]