#2151 Feature/mvi pattern

[JanFidor]

Add an MVI design pattern (includes pattern itself, tests, README.md and class diagram)

[iluwatar]

The build is failing. Please investigate @JanFidor

[JanFidor]

@iluwatar It seems an independent module is causing issues (page-object). My build is failing even on the master branch after syncing the fork. The first error is caused by missing test dependencies, after adding them this line throws an error java: incompatible types: java.util.List<java.lang.Object> cannot be converted to java.util.List<com.gargoylesoftware.htmlunit.html.HtmlAnchor> I'm not certain if I managed to break git on my part or if it's something else.

[iluwatar]

The error from the CI build is Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project model-view-intent: You have 2 Checkstyle violations. @JanFidor

[JanFidor]

@iluwatar my bad for misinterpreting logs and sorry for the delay, university gave me plenty of work this week, but I'll get right on it now.

[JanFidor]

@iluwatar fixed the violations, was a little closer to 60 after I run checkstyle locally, but it checks out now

[JanFidor]

Hi, @iluwatar sorry for the long break, but the past couple of weeks have been pretty crazy on my end, but I'll be getting on it now

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

98.7% Coverage
0.0% Duplication

[sonatype-lift[bot]]

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2177.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/iluwatar/java-design-patterns/2177.diff | git apply

Once you're satisfied commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.

[JanFidor]

@iluwatar I made the changes you suggested, I'm not certain what to do about sonatype-lift errors, especially when it comes to Lombok decorators and deleting the final keyword which would cause chackstyle errors (just like in the FSM PR)

[iluwatar]

Lift doesn't seem to handle Lombok annotations too well, so I think we can disregard them.

[iluwatar]

Looks good! Thank you for contributing this new pattern 🎉

@all-contributors please add @JanFidor for code

[allcontributors[bot]]

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

@JanFidor already contributed before to code